My twelve year old was raised on the 1962 St. Joseph’s Edition. We made memory cards and everything, and I drilled him every week (trying to make it as fun and rewarding as possible). He griped about it at the time, but now he says he wants to save the cards for his own kids.
He has moved on to the Faith and Life Series published by Ignatius Press (highly recommended ), but still has his old Catechism. Even at twelve, he can run theological rings around most Catholic adults.
If you are going to use it to teach your kids, there are a couple of thinks that are outdated (like some of the rules of marriage, cremation, fasting, and holy days. It also presents Limbo as de fide teaching, which it is not). These are few and far between, so if you stay a chapter ahead of your kids, you will be ready to give them some guidance.
Other than that, I can’t recommend it highly enough.